[DRAFT] Add -mfix-imm48 option #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cme
requested changes
Sep 15, 2023
Comment on lines
277
to
288
| auto ImmValueNeedsImm48Fix = [MI](int64_t Value) -> bool { | ||
| if ((MI->getOpcode() == Mips::Li_NM) && | ||
| (isUInt<16>(Value) || isInt<9>(Value) || ((Value && 0xfffu) == 0u))) | ||
| return false; | ||
| return ((Value & (1u << 9)) == (1u << 9)) || | ||
| ((Value & (7u << 8)) == (1u << 8)) || | ||
| (Value & 0x64005001u) == (0x24005001u); | ||
| }; | ||
|
|
||
| if (!ImmValueNeedsImm48Fix(Value)) | ||
| return false; |
There was a problem hiding this comment.
Single use of lambda, would be better to just use directly?
There was a problem hiding this comment.
Or I guess a static function for factoring out the logic of the code is even better.
draganmladjenovic
force-pushed
the
fix-imm48
branch
from
0846e70
to
a05fdd2
Compare
cme
approved these changes
Sep 26, 2023
|
@draganmladjenovic @cme can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs tests